fix: parse ova disk path from import output instead of fragile unused0 lookup#371
Merged
fix: parse ova disk path from import output instead of fragile unused0 lookup#371
Conversation
…0 lookup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 0a80c3a | Previous: cd476bd | Ratio |
|---|---|---|---|
tests/benchmarks/test_placeholder.py::test_import_time |
6964.507224353655 iter/sec (stddev: 0.000012275805525138683) |
6872.315979448821 iter/sec (stddev: 0.000018039316691679812) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the OVA template's disk import phase to parse the disk path from
qm disk importstdout (successfully imported '...'line) instead of readingunused0:fromqm config. Theunused0approach is fragile when importing multiple VMDK disks in a loop — after the first disk is attached, subsequent imports may not appear asunused0.Also adds
set -efor fail-fast behavior and explicit error handling if disk import fails.Addresses #370
Type of Change
Changes Made
qm disk importoutput instead ofqm configunused0 lookupset -eto the import script for fail-fast on errorsTesting
Checklist
doit format)doit lint)doit type_check)doit test)